search

mrsum / webpack-svgstore-plugin

Simple svg-sprite creating with webpack
https://www.npmjs.com/package/webpack-svgstore-plugin
200 stars 92 forks source link

v4.0.2: DOMContentLoaded does not working #162

Closed sectsect closed 6 years ago

sectsect commented 6 years ago

DOMContentLoaded added in v4.0.2 seems like does not fired. https://github.com/mrsum/webpack-svgstore-plugin/commit/e05eef676e6e1a1de8c46166450f5a75493cffd2

Thanks.

lgordey commented 6 years ago

@melloc01 pls, check this out

melloc01 commented 6 years ago

Hey @lgordey, added a helper function & used it on svgxhr: ref: https://www.sitepoint.com/jquery-document-ready-plain-javascript/

May you try my branch and check whether it fixes your issue @sectsect ?

Travis is failing, I'm commuting right now, will check as soon as I get home

sectsect commented 6 years ago

@melloc01

Thanks for your PR https://github.com/mrsum/webpack-svgstore-plugin/pull/163

I tried your branch fix/dom-access on my environment. It seems that the problem has been solved. Great work :tada:

melloc01 commented 6 years ago

cool @sectsect :) friendly ping @lgordey

lgordey commented 6 years ago

@melloc01 @sectsect Check 4.0.3 😉