mrsum / webpack-svgstore-plugin

Simple svg-sprite creating with webpack
https://www.npmjs.com/package/webpack-svgstore-plugin
200 stars 90 forks source link

Upgrades older Tapable.plugin methods to new hook/tap methods #173

Closed drolsen closed 3 years ago

drolsen commented 5 years ago

Webpack 4 has moved away from Tapable.plugin methods for new API hook/tap methods.

Please note, this moves the normalModuleFactory usage outside of the compiler.hooks.compilation tap due to scope change during API abstraction that leads to normalModuleFactory indexOf to never find a match unless re-scoped to the root of apply.

171

https://github.com/webpack/webpack/issues/6568

Thanks!