Fix onDOMLoad svgXHR call

[dmitriid]

Fix #75

[KhramtsovMaksim]

Please add this changes asap.

[mrsum]

@dmitriid @KhramtsovMaksim try 3.0.0-alpha.2

[mrsum]

@dmitriid Hi. fixed. You can override your svgXHR function

[KhramtsovMaksim]

Thank you!

[dmitriid]

How and where can I override this function?

[mrsum]

@dmitriid put function at your project and require that file or call function with svg argument for example

var __svg__ = { path: './assets/svg/**/*.svg', name: 'assets/svg/[hash].logos.svg' };
var spriteLoad = function(options) {
 $.ajax(options.filename)
}
spriteLoad(__svg__);

[dmitriid]

Aha. So __svg__ is a magical variable (this is not immediately apparent from the docs). One would assume that it's the svgXHR that does that. You have to look into the code of the function itself to see that it's not the case and that a variable is silently being overwritten by the plugin.

I'm am extremely sceptical about such a decision, to say the least.

Is previous behaviour available in any form (where you could specify a chunk to prepend the function to and not depend on magical variables somewhere in code)?

[mrsum]

@dmitriid svg – is the variable wich will modified inside webpack compile. As you know, import and require() commands are replace by ConstPlugin, i've made same logic with special variables. That is better than last implementation, cause you can create a lot of other sprites with only one SvgStore instance in webpack.config.js

Another case is opportunity of override svg ajax function, also AST compiler in webpack is much better than a lot of regexp and magic like in previous release. So, try to use it.

Best regards.

[dmitriid]

I will obviously try to use it. And ability to create multiple sprites is very nice.

However, magical variables that are silently overwritten? This is definitely obviously bad. import and require are known throughout JS world as:

• require: as an implementation detail for the most commonly used module system
• import: as part of the ES6 spec

Introducing not one, but several magical variables? That are silently overwritten? Erm... Nope.

[mrsum]

@dmitriid maybe, but a lot of plugins use same logic. for example https://github.com/js-next/react-style-webpack-plugin/blob/master/lib/entry.js#L10

[dmitriid]

It looks like it creates a different temporary variable, not relying on a pre-existing magic variable.