mrsum / webpack-svgstore-plugin

Simple svg-sprite creating with webpack
https://www.npmjs.com/package/webpack-svgstore-plugin
200 stars 92 forks source link

3.0.1 and 3.0.2 broke being able to find svg asset #99

Open roastlechon opened 8 years ago

roastlechon commented 8 years ago

usage code:

import svgxhr from 'webpack-svgstore-plugin/src/helpers/svgxhr';
import React, { PropTypes } from 'react';

const __svg__ = {
  path: './svg/**/*.svg',
  name: '/images/svg/[hash].icon.svg'
};

svgxhr(__svg__);

Network panel on dev tools and server shows:

/images/svg/[hash].icon.svg 500 14.228 ms - -
mrsum commented 8 years ago

Hi @roastlechon thx for issue. I'll see your report right now.

mrsum commented 8 years ago

@roastlechon could you fix on 3.0.0 version, i'll let you know when bug will fixed.

matpaul commented 8 years ago

@mrsum Sorry it's my fail, i check previous commit (Long term caching) in build time and it's work, but in webpack dev server i have same issue as above.

mrsum commented 8 years ago

@matpaul Don't worry about it ) I'll fix ASAP

matpaul commented 8 years ago

@mrsum Big Thx!

mrsum commented 8 years ago

@roastlechon @matpaul Guys, i've spent all day and best decision what i took is revert to version without caching support.

I've bring back 3.0.0 version as 3.0.3 cause i cant unpublish them. So, i'll back soon for resolving https://github.com/mrsum/webpack-svgstore-plugin/issues/98

roastlechon commented 8 years ago

Thanks for the quick reply/discussion @matpaul @mrsum. I fixed on 3.0.0 in my package.json.

matpaul commented 8 years ago

@mrsum any updates ?)

mrsum commented 8 years ago

@matpaul I finished for long-term caching support https://github.com/mrsum/webpack-svgstore-plugin/blob/feature/long-term-caching/src/svgstore.js

after testing, will publish new release in next few days