search

mrszj / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

OSGi classloading doesn't work with package-private dependencies #235

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
 Added a patch that demonstrates the problem.  Basically the problem is
that injected parameters seem to be bleeding access out to the users of the
class.

Original issue reported on code.google.com by sberlin on 14 Aug 2008 at 4:38

Attachments:

GoogleCodeExporter commented 9 years ago 
Disabling our OSGi-friendly classloader fixes this. I've disabled that 
classloader, and checked in your test:
  http://code.google.com/p/google-guice/source/detail?r=604

Original comment by limpbizkit on 14 Aug 2008 at 8:33

GoogleCodeExporter commented 9 years ago 
Thanks!  I'm heading out for three weeks in approximately 18 hours... so will be
silent for a bit.

Original comment by sberlin on 14 Aug 2008 at 8:42

GoogleCodeExporter commented 9 years ago 
Suggested patch that checks parameter visibility for methods and constructors.
Also includes an additional testcase and fixes a typo in the test module name.

Original comment by mccu...@gmail.com on 25 Aug 2008 at 9:36

Attachments:

GoogleCodeExporter commented 9 years ago 
Made minor performance improvement to patch

Original comment by mccu...@gmail.com on 28 Aug 2008 at 8:55

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by limpbizkit on 31 Aug 2008 at 2:24

GoogleCodeExporter commented 9 years ago 
As the next release will be Guice 2, I'm also thinking this line in common.xml:

  <property name="api.version" value="1.0"/>

should be changed to:

  <property name="api.version" value="2.0"/>

to reflect the new API level (this is also related to issue #243).

Original comment by mccu...@gmail.com on 10 Sep 2008 at 5:44

GoogleCodeExporter commented 9 years ago 
Updated patch for the latest trunk (note that this patch also renames
PackageVisilibityTestModule.java to PackageVisibilityTestModule.java)

Original comment by mccu...@gmail.com on 20 Sep 2008 at 2:29

Attachments:

GoogleCodeExporter commented 9 years ago 
Updated patch to work with latest trunk.

Original comment by mccu...@gmail.com on 5 Nov 2008 at 6:30

Attachments:

GoogleCodeExporter commented 9 years ago 
I've finally applied mcculls' patch with r710.

This changes mccull's original patch by using the System Class Loader if that 
was used to load the application 
classes. This should be a fairly reasonable thing to do, and it means users who 
aren't using OSGi or Java EE get a 
simpler experience.

Original comment by limpbizkit on 30 Nov 2008 at 1:02

GoogleCodeExporter commented 9 years ago 
Tested locally with peaberry and it passes all existing tests - thanks Jesse!

Original comment by mccu...@gmail.com on 30 Nov 2008 at 11:01