mrszj / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

Trunk guice-servlet depends on jarjar'd com.google.base.Throwables, but this isn't included in guice core #675

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
See http://groups.google.com/group/google-guice/msg/b4cb1abebae3fe85. I've 
removed the erroneous annotation from AbstractInjectorGrapherTest - and there's 
a separate issue for the failing Multibinding test 
(http://code.google.com/p/google-guice/issues/detail?id=670)

The remaining issue is the failing Servlet tests, which are caused by a new 
dependency from guice-servlet to com.google.base.Throwables. Unfortunately 
guice core doesn't jarjar Throwables because it doesn't directly depend on it. 
So we either need to tweak the build so that Guava classes the are only used by 
extensions are jarjar'd into the core - or find some way to jarjar the 
additional classes into the extension jar.

Alternatively we could revisit making Guava an external dependency of Guice - 
that's the approach we've been experimenting with in sisu-guice, and it has 
worked out fine so far (thanks to the compatibility between Guava releases).

Original issue reported on code.google.com by mccu...@gmail.com on 23 Dec 2011 at 10:39

GoogleCodeExporter commented 9 years ago

Original comment by mccu...@gmail.com on 23 Dec 2011 at 10:44

GoogleCodeExporter commented 9 years ago

Original comment by sberlin on 21 Jan 2012 at 4:41