search

mrtazz / checkmake

experimental linter/analyzer for Makefiles
MIT License
1.03k stars 45 forks source link

docker image build instructions are incorrect #58

Closed jimmywan closed 2 years ago

jimmywan commented 2 years ago

Expected behaviour

Instructions are valid

Actual behaviour

❯ docker build -e BUILDER_NAME="Your Name" -e BUILDER_EMAIL="your.name@example.com" . -t checker
unknown shorthand flag: 'e' in -e

Need to swap -e with --build-arg.

❯ docker build --help | grep build-arg
      --build-arg list          Set build-time variables
nedbat commented 2 years ago

In other words, this is the correct command:

docker build --build-arg BUILDER_NAME="Your Name" --build-arg BUILDER_EMAIL="your.name@example.com" . -t checker
jimmywan commented 2 years ago

In other words, this is the correct command:

Yes, which is why I made a PR to correct the README.