Open junaruga opened 2 years ago
I'm not 100% certain but I believe other make implementations (like BSD and posix make) don't allow the space before the colon. So the checker errs on the side of caution here.
I'm open to changing the rule and have a special rule for BSD make if that is useful. Or make it configurable in for this rule. However I also don't think it really hurts to just not have the space before the colon
Expected behaviour
The
checkmake
passes for the.PHONY : foo
(.PHONY<space>: foo
) in theMakefile
.Actual behaviour
The
checkmake
complains for the.PHONY : foo
(.PHONY<space>: foo
) in theMakefile
. I used thisMakefile
https://github.com/junaruga/cpp-test/blob/report-checkmake/src/MakefileSeeing the GNU make
PHONY
document, there are 2 examples for both.PHONY: foo
(without space) and.PHONY : foo
(with space). So I assume both are valid. https://www.gnu.org/software/make/manual/make.html#Phony-TargetsThe
checkmake
passes theMakefile
by applying the following patch. So, I assume that the.PHONY : foo
(with space) is judged as invalid. But why?Output of
checkmake --version
There is no version info. The
checkmake
was installed today by the steps I wrote at https://github.com/mrtazz/checkmake/issues/62 .Output of
checkmake --debug <your makefile>
Output of
make --version
Sample Makefile to reproduce issue
(some of these things might not apply but the more you can provide the easier it will be to fix this bug. Thanks!)
Here is the sample
Makefile
as I wrote above. https://github.com/junaruga/cpp-test/blob/report-checkmake/src/MakefileThanks!