mrtazz / checkmake

experimental linter/analyzer for Makefiles
MIT License
1.04k stars 45 forks source link

Fix Dockerfile to build on podman. #66

Closed junaruga closed 1 year ago

junaruga commented 2 years ago

Hello,

This commit fixes the following error on podman that is used mainly on Fedora, RHEL.

$ podman --version
podman version 3.4.4

$ podman build --build-arg BUILDER_NAME='Your Name' --build-arg BUILDER_EMAIL=your.name@example.com -t checkmake .
[1/2] STEP 1/5: FROM golang:1.13 AS builder
[1/2] STEP 2/5: ARG BUILDER_NAME BUILDER_EMAIL
[2/2] STEP 1/5: FROM alpine:3.9
Error: error building at STEP "ARG BUILDER_NAME BUILDER_EMAIL": ARG requires exactly one argument definition

Checklist

Not all of these might apply to your change but the more you are able to check the easier it will be to get your contribution merged.

junaruga commented 2 years ago

I am not sure why this PR's GitHub Actions is not executed.

trinitronx commented 2 years ago

I am not sure why this PR's GitHub Actions is not executed.

Maybe it's because permissions are needed? I just created a PR (#69) and it says this:

1 workflow awaiting approval First-time contributors need a maintainer to approve running workflows.

Screen Shot 2022-04-27 at 5 21 06 PM
yegorich commented 1 year ago

Fixes docker building for me too. My system: Ubuntu Bionic Beaver, Docker: 18.06.1-ce, build e68fc7a

mrtazz commented 1 year ago

thanks for taking the time to contribute!