mrtazz / checkmake

experimental linter/analyzer for Makefiles
MIT License
1.04k stars 45 forks source link

Reduces files to the built-in makefile type for pre-commit #77

Closed colindean closed 1 year ago

colindean commented 1 year ago

As nudged here, but this won't be fully effective until https://github.com/pre-commit/identify/pull/353 is merged.

I think this is safe to merge before 353 because so few people use *.make... I think I've seen it maybe a few times in 20 years. Also, this hook is so new to checkmake that probably not that many people are using it yet.

Checklist

Not all of these might apply to your change but the more you are able to check the easier it will be to get your contribution merged.

colindean commented 1 year ago

All of the upstream stuff is merged, so this can go in, @mrtazz

colindean commented 1 year ago

@mrtazz this is safe to merge now

colindean commented 1 year ago

@mrtazz Any chance for a merge?

mrtazz commented 1 year ago

sorry for the delay. Thanks for taking the time to contribute

colindean commented 1 year ago

Thank you! Could you perhaps do a release so that folks using the pre-commit hook can point to a tag instead of a hash?

colindean commented 1 year ago

@mrtazz Any chance for a tag?