Closed michael-delarue-axomic closed 1 year ago
BTW; I have the weird situation that in one repo using the code below seems to solve it but not in the other
- repo: https://github.com/trinitronx/checkmake/
rev: 0.2.2
hooks:
- id: checkmake
files: Makefile
N.B. This is not the main mrtazz repo
Ping @trinitronx
I have proposed a very simple fix for checkmake which appears to fix these problems for me.
If I run with
- repo: https://github.com/michael-delarue-axomic/checkmake.git
rev: 4c3809bc541f45e7793d37ce06f67496123f8e23
hooks:
- id: checkmake
files: Makefile
Then checkmake is working for me. If anyone's following and has the same problems, please report in this ticket or on the PR if this fixes them for you.
Your suggested hash for rev
is correct. When https://github.com/mrtazz/checkmake/pull/69 added the pre-commit config to the README, I think we anticipated @mrtazz releasing 0.2.2 shortly thereafter but it has not yet come to pass.
There is now a v0.2.2 release https://github.com/mrtazz/checkmake/releases/tag/0.2.2
Expected behaviour
Adding checkmake to the pre-commit file should install checkmake and work
Actual behaviour - version 0.2.2
run pre-commit run -a outputs
Actual behaviour - version 0.2.1
run pre-commit run -a outputs
Actual behaviour - version 0.2.1
run pre-commit run -a outputs
Output of
checkmake --version
n/a - not installed locally
Output of
checkmake --debug <your makefile>
n/a - not installed locally
Output of
make --version
Sample Makefile to reproduce issue
n/a - no Makefile needed.