Append new line between records when using custom --format

mrtazz / checkmake

experimental linter/analyzer for Makefiles

MIT License

1.02k stars 44 forks source link

Append new line between records when using custom --format #98

Open adelplanque opened 1 month ago

adelplanque commented 1 month ago

According to the documentation, when using the --format option, each error report must end with a new line, which is not the case.

Checklist

Not all of these might apply to your change but the more you are able to check the easier it will be to get your contribution merged.

[ ] CI passes
[ X] Description of proposed change
[ X] Documentation (README, docs/, man pages) is updated
[ ] Existing issue is referenced if there is one
[ X] Unit tests for the proposed change

adelplanque commented 1 month ago

I just saw #55, but in #54 only deletion of \r was requested. All lint tools I know use a breakline between error reports. The standard under Unix is a simple \n. That's why I think it would be a good idea to restore a \n at the end of each error. Even if we obtain the same effect with {{"\n"}}, this seems to me a tricky way of proceeding for someone who does not know the Go language. A better solution might be to add \r\n or \n depending on the OS.