SSL Errors - Githubissues

mrtazz / restclient-cpp

C++ client for making HTTP/REST requests

http://code.mrtazz.com/restclient-cpp/

MIT License

1.57k stars 377 forks source link

SSL Errors #13

Closed Grunge closed 10 years ago

Grunge commented 10 years ago

Hia, thanks for your work.

I Suggest two additions to go around ssl errors. Maybe switchable via parameter or however you like:

Parameter "insecure" and then: //SSL Ignore all err curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, false); curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, false); curl_easy_setopt(curl, CURLOPT_SSLVERSION, 3);
Parameter "verbose"
//get error details curl_easy_setopt(curl, CURLOPT_VERBOSE, 1);

Greetings & Thanks Philipp

mrtazz commented 10 years ago

I like the idea of setting verbosity level. Do you think there should be some more smarts around it to stuff it into a custom logger or is printing to STDOUT/STDERR fine here?

I'm a little hesitant about the insecure option. I had this marked as an issue before (https://github.com/mrtazz/restclient-cpp/issues/2) and decided against it, as I think the cert should always be checked and if it fails verification you should set up the certs on the OS level to be trusted.

Grunge commented 10 years ago

hmm, i'm using Qt, so i return values with qDebug()... keep it simple as you like. People can change the code and create pull request if they need a solution.