search

mrthinger / wow-voiceover

ml world of warcraft voiceover addon
https://www.curseforge.com/wow/addons/voiceover
The Unlicense
455 stars 47 forks source link

Cata Update broke NPC Gossip Voice Reading #129

Open Akarficus opened 1 month ago

Akarficus commented 1 month ago

The affected code is in VoiceOver.lua and it causes errors to pop up when talking to NPCs because the get gossip text function and get number of active gossip quests function got renamed in the Cata Classic update.

On line 341 of VoiceOver.lua, "local gossipText = GetGossipText()" should now be "local gossipText = C_GossipInfo.GetText()" On line 290 of VoiceOver.lua, "local numActiveQuests = GetNumGossipActiveQuests()" should now be "local numActiveQuests = C_GossipInfo.GetNumActiveQuests()" On line 291 of VoiceOver.lua, "local numAvailableQuests = GetNumGossipAvailableQuests()" should now be "local numAvailableQuests = C_GossipInfo.GetNumActiveQuests()"

This fixes the errors and allows the NPCs to be voiced when talking to them, as intended.

mrthinger commented 1 month ago

can you submit a PR with the fixes?