search

mrthuanvn / wot-xvm

Automatically exported from code.google.com/p/wot-xvm
GNU General Public License v3.0
0 stars 0 forks source link

2.5.3 update still has problems with (roman) vehicle tier over-tank markers #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
standard over-tank marker settings are still interfering (in 2.5.3) with my 
customised XVM configuration settings for the over-tank (roman) vehicle tier 
markers, even when using the setting "useStandardMarkers": false.

The problem only appears to affect Ally tanks in all four visual modes 
(alive/dead in normal- and and alt-view). Enemy tanks (in all four possible 
visual modes) are behaving properly.

It looks like the fix in 2.5.3 to address the broken standard markers caused by 
2.5.2 has not been fully resolved.

Original issue reported on code.google.com by damo1...@gmail.com on 29 Aug 2012 at 4:04

GoogleCodeExporter commented 9 years ago 
Follow-up Comments and Additional Insights:
After running a few more battles since reporting this bug I have noticed that 
the problem initially manifests with incorrectly placed roman over-tank markers 
on all Ally tanks that I can see during the initial spawn. If I lose visual 
contact with an  Ally tank and then subsequently re-establish visual contact 
with that same tank then the problem resolves itself and the roman over-tank 
markers *for that specific tank* will correctly show in my customised on-screen 
position. For any Ally tanks that I never lose visual contact with after 
initial spawn, the roman over-tank markers remain incorrectly positioned 
on-screen throughout the entire battle.

The Enemy tanks always show the correct customised roman over-tank marker 
locations because I never see them during the initial spawn.

This bug seems to resolve itself after a "visual contact refresh" (my term) has 
occured (i.e. initial visual from spawn is lost, then re-established).

I haven't altered the roman over-tank markers setting for of my custom XVM 
config file, which worked fine up to and including v2.5.1.

To clarify, I have custom-configured XVM to show roman over-tank markers in 
slightly different on-screen locations over the tanks than the standard 
"vanilla" in-game settings use. When the problem manifests, the roman over-tank 
markers appear as they would using the "vanilla" in-game settings, not in 
accordance with my custom config file.

Hope this is clear enough

Original comment by damo1...@gmail.com on 29 Aug 2012 at 5:13

Attachments:

GoogleCodeExporter commented 9 years ago 
Yes, it's clear, but I don't know what to do with this issue.
1. It is bug, but you can use workaround - disable label icon and create text 
field with "{{rlevel}}" macro. You can even setup color, shadow, size, ...
2. We started complete code refactoring, and this issue will be closed 
automatically, but it will not be ready soon.
3. It is not so good to do releases frequently.

What you say?

Original comment by m.schedr...@gmail.com on 29 Aug 2012 at 6:42

GoogleCodeExporter commented 9 years ago 
Thanks for the quick reply. I understand the reluctance to do updates too 
frequently.

ok, I can disable "levelIcon" but I'm not really sure how to create the text 
field with the "{{rlevel}}" macro. Do you have any tips or sample code I could 
use as a guide to get me started?

Many thanks.

Original comment by damo1...@gmail.com on 30 Aug 2012 at 1:10

GoogleCodeExporter commented 9 years ago 
I'll take it.

levelIcon is original WoT marker component.
Not much you can make about it
"levelIcon": {
            "alpha": 100,
            "visible": false,
            "x": 20,
            "y": -21
That's all

But {{rlevel}} is out own implementation suitable for "textFields" section.
Copypaste any textField section. Change its "format": from {{vehicle}} to 
{{rlevel}}.
Check semicolons between sections
"textFields": [{},{},{},{}]
Voila. Eyecandy at your service.

Original comment by ilitvinov87@gmail.com on 30 Aug 2012 at 11:38

GoogleCodeExporter commented 9 years ago 
Righty oh. I'll have a crack at using {{rlevel}}.

Many thanks for your support with this great mod! :-)

Original comment by damo1...@gmail.com on 30 Aug 2012 at 11:45

GoogleCodeExporter commented 9 years ago 
I confirm this problem for 2.5.3, but conditions in my case are even worse.

Current developing branch is not affected. Thus next release is expected to be 
okay with this.

Damo, please, tell us if this problem persists in next release. Version will be 
3.0.0. Right now it is not available for download. Will see.

Thanks.

Original comment by ilitvinov87@gmail.com on 30 Aug 2012 at 12:43

GoogleCodeExporter commented 9 years ago 
Will do.

Original comment by damo1...@gmail.com on 30 Aug 2012 at 1:50

GoogleCodeExporter commented 9 years ago 
Reopened, because bug is present even with levelIcon turned off.

Original comment by m.schedr...@gmail.com on 30 Aug 2012 at 7:52

GoogleCodeExporter commented 9 years ago 
Confirming issues with roman vehicle tier icons. In my case, only allied 
vehicles are affected (as well). I'm using a "hand-made" custom config since 
XVM 2.0.0 that was gradually adapted to the config file changes introduced with 
(nearly) every new release.

Change from 2.5.2 to 2.5.3 seems to have introduced that bug now.

Vehicle tier markers are present for ALL enemy vehicles, whereas they're 
missing for ALL allied vehicles.

Relevant sections from XVM.xvmconf (identical for enemies & allies):

"levelIcon": {
            "visible": true,
            "x": 0,
            "y": -94,
            "alpha": 100
          }

Original comment by hefem...@gmail.com on 2 Sep 2012 at 4:08

GoogleCodeExporter commented 9 years ago 
Bug located.

See build 715
http://code.google.com/p/wot-xvm/source/detail?r=715

Config is not loaded in time when round starts.
I dont want to mess up with fixing it in 2.5.3.
Will try to release 3.0.0-alpha1 in a few days if m.schedriviy will not get in 
contact.

Original comment by ilitvinov87@gmail.com on 3 Sep 2012 at 6:41

GoogleCodeExporter commented 9 years ago 
Fixed for branch-2.5.

m.schedriviy, please confirm, if this very tiny and dirty hack is acceptable.

http://code.google.com/p/wot-xvm/source/detail?r=716

Original comment by ilitvinov87@gmail.com on 6 Sep 2012 at 2:12

GoogleCodeExporter commented 9 years ago 
Dirty fix completely breaks useStandartMarker option.

Opened.

Original comment by ilitvinov87@gmail.com on 7 Sep 2012 at 12:06

GoogleCodeExporter commented 9 years ago 
Another dirty fix. Both levelIcon and StandartMarker works ok. Will try to 
release 2.5.4 now.

See build 719
http://code.google.com/p/wot-xvm/source/detail?r=719

Workflow at XVM.as for 2.5 branch is now even more ridiculous.

Original comment by ilitvinov87@gmail.com on 7 Sep 2012 at 2:48

GoogleCodeExporter commented 9 years ago 
Released 2.5.4. Guys, please, report how is it going.
http://code.google.com/p/wot-xvm/downloads/detail?name=xvm-full-2.5.4.zip

Original comment by ilitvinov87@gmail.com on 7 Sep 2012 at 4:33

GoogleCodeExporter commented 9 years ago 
Will do. Just downloaded it now and will run it through the weekend and will 
then report back.

Original comment by damo1...@gmail.com on 8 Sep 2012 at 1:19

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I have spent the past couple of days running the new build and the bug that I 
originally reported appears to now be fixed insofar as it relates to my custom 
XVM configuration.

Many thanks! :)

Original comment by damo1...@gmail.com on 10 Sep 2012 at 3:14

GoogleCodeExporter commented 9 years ago 
For me, 2.5.4 seems to have fixed the issue, too.

Thanks a lot!

Original comment by hefem...@gmail.com on 10 Sep 2012 at 2:20

GoogleCodeExporter commented 9 years ago

Original comment by m.schedr...@gmail.com on 10 Sep 2012 at 3:08

GoogleCodeExporter commented 9 years ago

Original comment by ilitvinov87@gmail.com on 19 Aug 2013 at 4:27