search

mrtnzlml-archive / testbench

:green_apple: Simple integration testing tool for Nette applications
http://zlml.cz/jednoduche-testovani-pro-uplne-kazdeho
41 stars 13 forks source link

PHP 7.2 Compatibility #51

Closed konecnyjakub closed 7 years ago

konecnyjakub commented 7 years ago

PHP 7.2 does not allow to use Object as class name, any attempt to extend it (Nette\Object here) results in a fatal error. So I used trait Nette\SmartObject instead. Tests on PHP 7.2 still fail because of Kdyby packages which still use Nette\Object. If one does not use Doctrine, there should be no errors (I believe).

mrtnzlml commented 7 years ago

Hi, please rebase it on top of the master branch (green tests). Also if the tests are failing then I cannot really merge it, sorry.

Please also note this warning in "readme" file:

At this moment I don't have time, energy and money to maintain this project. But it's a shame so if you depend on this project and you want to become a sponsor or develop it further please don't hesitate to contact me. Otherwise, I am not able to guarantee bright future of this repo... :)

Thanks for understanding.

konecnyjakub commented 7 years ago

Rebase done. I can allow failures with 7.2 or do not test on it at all. What would you prefer?

mrtnzlml commented 7 years ago

Allow it in failures makes sense to me until somebody will fix it...

konecnyjakub commented 7 years ago

So allow failures? Do note that these errors do not come from this package's code but its dependencies.

mrtnzlml commented 7 years ago

Yes, allow failures (until the 3rd party libraries are fixed).

konecnyjakub commented 7 years ago

Alright, done.

mrtnzlml commented 7 years ago

Good, also please keed unified coding standard with this project (use tabs please).

konecnyjakub commented 7 years ago

Sorry about that. It is fixed now.

mrtnzlml commented 7 years ago

Ok, merged. Thanks.