Python 3.7 Support + Small Tweaks

[maxnumbers]

@mrtolkien Changes/Rationale below:

leaguepedia_parser/_tests/test.ipynb

• Added a python notebook for iterative testing... Maybe not useful to you, but helpful for quick tests and verification

leaguepedia_parser/parsers/game_parser.py

• Changed the help info for leaguepedia_parser.getplayers() so that it reflects the correct field, "name", required for query to succeed (My VS Studio is stupid about formatting and won't let me save without it fiddling with it, so pay the spacing changes no mind)_

leaguepedia_parser/transmuters/game.py

• Added a quick version check that'll allow people running versions of Python older than 3.8 to use this as well by using typing_extentions
• I'll be adding this these changes to lol-dto as well if this is approved, so be on the lookout for that

leaguepedia_parser/transmuters/game_players.py and leaguepedia_parser/transmuters/tournament.py

• "Added a quick version check..." (see above)

[mrtolkien]

Thanks for the help! Unfortunately your pull request does not pass the tests and does not adhere to the coding guidelines of the project so I have to reject it at the moment.

Regarding python 3.7 support, I don’t think it is very wise to add it since almost all the type hints are TypedDicts. It will make every single file much more verbose without a real gain in the long run. I also sometimes use the walrus operator and the new f string options which cannot be ported to 3.7.

For the Jupyter notebook, I think it’s great for you to test stuff! But if you want to commit it to the repo it needs to be a standard pytest test file. We should not add random files to the repository.

Here are the steps to take for me to accept the PR:

• Remove the 3.7 compatibility code
• Remove the Jupyter notebook or create new tests with pytest
• Get the tests passing on your branch
• Format the code with black

Sorry for being such a pain and thanks again for the interest! GL HF.

[maxnumbers]

@mrtolkien It's completely understandable that you have an expected format! I've gotta take some time to understand pytest, as I had no idea that's what those modules were, and then I'll re-submit.

Thanks for taking the time to explain so thoroughly! :)