search

mrtolkien / leaguepedia_parser

A parser for the Leaguepedia website, focused on gathering esports data.
MIT License
71 stars 18 forks source link

Typed Dict - typing_extensions #11

Closed lolThinked closed 3 years ago

lolThinked commented 3 years ago

Error: from typing import TypedDict, Dict, List, Optional ImportError: cannot import name 'TypedDict'

Fix: if sys.version_info[0] == 3 and sys.version_info[1] >= 8: from typing import TypedDict, Literal else: from typing_extensions import TypedDict, Literal

mrtolkien commented 3 years ago

I do not plan on supporting pre 3.8 versions, there would be other issues as well with my use of the walrus operator in other places.

lolThinked commented 3 years ago

Yep. I did notice that after I added a fix for every import used. My bad.

This is totally amazing though, that you created this🥰

ons. 26. mai 2021, 03:55 skrev Tolki @.***>:

I do not plan on supporting pre 3.8 versions, there would be other issues as well with my use of the walrus operator in other places.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mrtolkien/leaguepedia_parser/issues/11#issuecomment-848397249, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALT2X5RLQZM2IPYORMZHNVDTPRIKHANCNFSM45PZDAPQ .