Added *.ipynb to gitignore, updated readme, change help verbage

[maxnumbers]

@mrtolkien I used black formatting this time, so I'm not sure why it changed the spacing/indentation on certain lines, but here's the changes/info for this pull request:

• I changed the readme, but tried to keep it in a similar format to lol-dto.

• I added .ipynb to the gitignore since you said that you don't want to add notebook files (and at the moment they're not compatible with Python 3.8 because of conda)

• Made the changes to the verbage of the "get_games" help text so that it says that the function input is tournament name

• All tests are passing

[maxnumbers]

Sidenote: What do you think of the following for game_parser.py in reference to "TODO Make that more beautiful"

def _add_game_players(game: LolGame, add_page_id: bool) -> LolGame:
    """Joins on PlayersRedirect to get all players information.
    """
    # TODO Make that more beautiful, not satisfied with black’s formatting

    agp_str = [
        [
            "ScoreboardGames, ScoreboardPlayers, PlayerRedirects, Players",
            ", _pageData = PD",
        ],
        ["ScoreboardGames.UniqueGame = ScoreboardPlayers.UniqueGame, "],
        ["ScoreboardPlayers.Link = PlayerRedirects.AllName, "],
        [
            ", Players._pageName = PD._pageName",
            "PlayerRedirects._pageName = Players._pageName",
        ],
        [", PD._pageID=pageId"],
        [
            "ScoreboardGames.UniqueGame = '{game['sources']['leaguepedia']['uniqueGame']}'"
            "AND PD._isRedirect = 0",
        ],
    ]

or

def _add_game_players(game: LolGame, add_page_id: bool) -> LolGame:
    """Joins on PlayersRedirect to get all players information.
    """
    # TODO Make that more beautiful, not satisfied with black’s formatting
    agp_str = [
        "ScoreboardGames, ScoreboardPlayers, PlayerRedirects, Players",
        ", _pageData = PD",
        "ScoreboardGames.UniqueGame = ScoreboardPlayers.UniqueGame, ",
        "ScoreboardPlayers.Link = PlayerRedirects.AllName, ",
        ", Players._pageName = PD._pageName",
        "PlayerRedirects._pageName = Players._pageName",
        ", PD._pageID=pageId",
        "ScoreboardGames.UniqueGame = '{game['sources']['leaguepedia']['uniqueGame']}'"
        "AND PD._isRedirect = 0",
    ]

or

    agp_ln1 = [
        "ScoreboardGames, ScoreboardPlayers, PlayerRedirects, Players",
        ", _pageData = PD",
    ]
    agp_ln2 = [
        "ScoreboardGames.UniqueGame = ScoreboardPlayers.UniqueGame, ",
    ]
    agp_ln3 = [
        "ScoreboardPlayers.Link = PlayerRedirects.AllName, ",
    ]
    agp_ln4 = [
        ", Players._pageName = PD._pageName",
        "PlayerRedirects._pageName = Players._pageName",
    ]
    agp_ln5 = [
        ", PD._pageID=pageId",
    ]
    agp_ln6 = [
        "ScoreboardGames.UniqueGame = '{game['sources']['leaguepedia']['uniqueGame']}'"
        "AND PD._isRedirect = 0",
    ]

I think they're all pretty... not pretty... but the last option seems okay.

[mrtolkien]

Looks better with the tests passing!

I’ll take a look at it later, but I’ll likely have to revert your change in get_games since it uses the tournament "overview page" field and not name. The doc was not properly updated, but not the variable name!

[maxnumbers]

Ahhhhh I get it now, yeah I was definitely wrong on that change.

I think I got confused because I was mostly working with the test file, and the list name with overview pages was "tournament_names".

[maxnumbers]

@mrtolkien when you redo the README.md, if you include a To-Do list for the parser of things you'd like worked on (similar to the one in lol-dto), I'll work on them. I'm currently working through the ones you already had listed as commented "TODO".

I'm kinda trying to help out with the parser, and other data gathering tools you've started the work for, as a means of contributing to the data science community for LoL while improving my basic python skills.

[mrtolkien]

Will do! I think the most pressing thing is to add functions to query other tables on Leaguepedia. I don’t personally use things like standings, schedule, and so on and so forth, but having easy access to them in python is definitely convenient for some people!