mrtommyb / ktransit

A simple exoplanet transit modeling tool in python
GNU General Public License v3.0
53 stars 20 forks source link

reversed order in norm_by_quarter #12

Closed exowanderer closed 6 years ago

exowanderer commented 6 years ago

In the function norm_by_quarter, the order of first median normalizing the flux, then median normalizing the ferr results in dividing the ferr by exactly 1.0. If you reverse the order and first normalize ferr by the median of flux -- then normalize flux by the median of flux -- then the ferr is properly normalized, which effects the weights inside the fitting procedure.

mrtommyb commented 6 years ago

Yes, you're quite right.