mruby-zest / mruby-zest-build

Root repo for mruby-zest containing links to all submodules
GNU Lesser General Public License v2.1
19 stars 24 forks source link

Add resonance tab to PADsynth #78

Closed dancesWithBugs closed 2 years ago

dancesWithBugs commented 2 years ago

Implements zynaddsubfx/zyn-fusion-issues#358

I noticed that PADsynth didn't have a resonance view, so I tried adding it. I essentially re-used the panel from ADDSynth. It seems to be working, that is, I can access the resonance panel in PADsynth, and enabling resonance and turning the knobs has an effect on the sound. However, as I am wholly unfamiliar with this codebase, I would appreciate someone with experience to double check if everything is working as intended.

Previously posted at https://github.com/mruby-zest/mruby-zest/pull/59, but seeing how there are more recent commits in this repo, perhaps this PR belongs here instead?!