Closed marahmbawwab closed 1 year ago
This change looks good to me now, thanks for taking into account all the comments. I can spend some time with you later to give more details about this "not working with the master branch suggestion".
I'll let @fundamental finish the review since I don't have merge permissions on this repo.
Thanks for the contribution :+1:
Hello Marah,
Thanks for the contribution and I'm glad to see that hotloading works on windows with minimal changes.
Would you mind updating the commit message to something more informative? In this project we roughly conform to the git message conventions documented in https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html .
In this case something along the lines of:
You should be able to update your commit by changing it locally via
git commit --amend
and then update your fork via agit push --force
command.Also a minor note, but generally creating a branch in your fork to create pull requests for is a best practice. It's never strictly necessary, but it does avoid headaches when multiple PRs are occurring, or if your repo's history otherwise gets out of sync with the upstream repository.