search

mruettgers / SMLReader

ESP8266 based smart meter (SML) to MQTT gateway
GNU General Public License v3.0
289 stars 67 forks source link

WIP: make sensors web configurable #54

Open mpolitze opened 1 year ago

mpolitze commented 1 year ago

Thank you for the awesome work! I had the issue that I did not want to recompile the firmware when installing an ESP. To solve that I moved configuring sensors to the web interface. I also added an option to publish JSON formatted MQTT payloads which is required by thingsboard and added a small /status page. I would appreciate if you accept this pull request.

Note: The changes ran quite smoothly for several weeks. I just made final adoptions to merge your latest changes from v3.0.0 and updated my ESP. The last hour seemed good. I will give feedback in a couple of days if everything is still running as expected.

mruettgers commented 1 year ago

Thank you! This would be a great addition to the project. I'll look forward to your feedback.

I found one thing, that is likeley to make troubles and I'll comment it within the code.

mpolitze commented 1 year ago

thanks for the review! I added a couple of lines to use the stored lastWillTopic and to keep the lastWillPayload in memory in the json case.

mpolitze commented 1 year ago

The sensor now ran with the merged changes for the last couple of days. MQTT survived router reboots and internet connection losses in between. I would greatly appreciate if this could be merged.

mruettgers commented 1 year ago

I am sure that I will merge the PR. But before that I would like to test it myself and we still need to update the manual because the configuration is not preserved during the update and the configuration via web interface still needs to be explained in the readme.

Since I have very little time right now, I don't know when I will get to it.

mruettgers commented 1 year ago

I haven't forgotten the PR, I'm just busy with my bachelor thesis at the moment and won't have time to work on SMLReader again until March.

GreyPenguin commented 1 year ago

Good luck with the thesis