search

mrusse / soularr

A Python script that connects Lidarr with Soulseek!
77 stars 7 forks source link

number_of_albums_to_grab documentation is misleading #34

Closed l2noob2 closed 3 weeks ago

l2noob2 commented 3 weeks ago

How mancy records to grab each run, must be a number between 1 - 2,147,483,647

number_of_albums_to_grab = 10

This is misleading since this actually refers to page size used when searching over a loop.

I would propose renaming this configuration variable to simply "page_size" to avoid confusion.

mrusse commented 3 weeks ago

I sort of agree but the number does equal to the number of albums the script will try to grab on each run so I would not say it is misleading. I do however have some updates coming that will make the functionality line up more with the name of the setting. I would also not change it either way since people are already using the setting and forcing them to change the naming would cause even more confusion...