mrusse / soularr

A Python script that connects Lidarr with Soulseek!
77 stars 7 forks source link

add some extra options to config.ini #7

Closed AdamWHY2K closed 1 month ago

AdamWHY2K commented 1 month ago

new options:

mrusse commented 1 month ago

I like these options. Only thing I'm worried about is forcing users to update their config with these params. Would it be possible to make them all optional (i.e. have it so the script wont crash if they are not present). One other nitpick (sorry) is that I would prefer to have placeholder values in the example config blacklist and readme. For example: title_blacklist = blacklistword1,blacklistword2

Again sorry for nitpicking! Let me know what you think.

AdamWHY2K commented 1 month ago

no worries, those are good points.

blacklist words changed in 0008b74 fallback values for new params added in 1cdb95c

mrusse commented 1 month ago

Looks good, just fixed one issue I found with the blacklist always getting triggered on the album name if the list wasnt in the config. "word" would be '' and since '' in any_string is always true it would always trigger.