Suggestions :)

[ViSTiE]

Hi MrV,

I've been working with your scripts and used the update-sui script lately. It's been working great and I've nothing to complain about. I only have some minor suggestions you can think about.

• I'd personally pipe the output of actions under [INFO] Check out GIT repo to dev\null. These actions are mainly git clone, git fetch upstream, git checkout, and curl -fLJO, since these produce an outcome that is not very useful information to have displayed in the terminal and can be omitted in my opinion.
• In the install script, I'd implement a check if screen and jq have already been installed on the machine and if not, install them. I'd also add a new paragraph under the Getting Started section, on how to update the Sui node by simply adding screen -S sui -m bash ./update-sui.sh and some short descriptive words.
• Update: I just finished the update script and (just for fun) executed it again. My expectation was that my local and the remote version should be the same now. But the script says, my local version is 0.6.2 whereas the remote version is 0.6.3. So, has the update not been installed?
• Is it possible to also install the Sui binaries alongside the build of the Sui node? This would make commands such as sui --version available.

That's it for the moment, been looking forward to more updates :) Thank you for this great and useful work!

[mrv777]

Thank you for testing it out and the feedback. I did take your suggestion and pipe some of that output to clean it up.

There is a check for jq already, but not one for screen. However, screen is never used in the script and prefer to keep it to dependencies the script needs. Screen is likely called before the script anyways, so checking for it is a bit late.

As for the update script, I will have to check, there is sometimes a delay with the devnet releases and the GitHub tags I think so it may have just been bad timing.

Yeah, I think an option to add the binaries is a good idea.

[ViSTiE]

Hi,

sorry to bother you again, but I just downloaded the latest version of the scripts and tried to execute the update-sui script, but it fails due to this error:

I even cloned the whole repo, but this issue persists.

Any idea what I can do?

[mrv777]

Oh, sorry about that bug. I should add a better update script. You need to manually download the VERISON file or update the number in it to 4

[ViSTiE]

So I changed the number in the VERSION file to 4 and it works now.