search

mrvilla / collection

collection of related queries
https://mrvilla.github.io/collection/
0 stars 0 forks source link

Error handling #1

Closed Toastbroad closed 5 years ago

Toastbroad commented 5 years ago

https://github.com/mrvilla/collection/blob/fc2f42d057590389ce0088c9507eae0217494e0a/src/app/shared/data/externtalData.js#L4

What about error handling here? If one of the fetches throws an error, the entire Promise.all fails also. This can be avoided :)

mrvilla commented 5 years ago

@Toastbroad yes, added a catch to each fetch. found out that my comicvine api does not work locally.

mrvilla commented 4 years ago

thanks again! QL

mrvilla commented 4 years ago

thanks again! QL

mrvilla commented 4 years ago

thanks again! QL

mrvilla commented 4 years ago

thanks again! QL