mrvivacious / My_Bhagavad_Gita

Krishna, heard through the medium of Alexa
https://www.amazon.com/Vivek-Bhookya-My-Bhagavad-Gita/dp/B0828YQ2GW/
MIT License
6 stars 9 forks source link

[webui] show "no results" on search page #23

Closed mrvivacious closed 1 year ago

mrvivacious commented 1 year ago

Story description

  1. go to https://mrvivacious.github.io/My_Bhagavad_Gita/
  2. click on Search
  3. Search for "mrvivacious"
  4. note that Search has no results

Acceptance criteria: Pull request is created. In that request, a search with no results should show the text "no results found for query"

Work description: This is where the output could go

You might want to do a check for the resulting output before this line

bilalmirza74 commented 1 year ago

hi @mrvivacious i want to work on this assign me

i will create PR soon

bilalmirza74 commented 1 year ago

@mrvivacious

Bro please add "hacktoberfest" Label 🏷️ before you merge my PR

mrvivacious commented 1 year ago

Ah sorry I merged before seeing your hacktoberfest comment. I'll add the label to this issue later today and then I'll reference your commit here as a comment 👍

bilalmirza74 commented 1 year ago

Okay thanks I will consider your changes Then PR Again 👍

mrvivacious commented 1 year ago

i added the label

mrvivacious commented 1 year ago

resolving thanks to https://github.com/mrvivacious/My_Bhagavad_Gita/commit/1e555350646e50ad4e037938e089b0613576029e

mrvivacious commented 1 year ago

Assigned u