search

mrweikiat / pe

0 stars 0 forks source link

Feature flaw with address #8

Open mrweikiat opened 3 years ago

mrweikiat commented 3 years ago

It was provided in UG that address can be any value However, this might be a possible feature flaw as the purpose of address is for the user to correctly determine the address of a CCA member. As a welfare IC, they might need to send certain packages to the address of the member. Therefore a valid address might be more feasible

image.png

The address is a proxy invalid address, this does not serve any purpose for identifying the place of stay. Therefore, I feel that inputting address as any value undermines the purpose of address. And should be carefully specified in the UG and DG, as a valid address tag, with certain errors thrown if the address is wrong etc

image.png

nus-pe-bot commented 3 years ago

Team's Response

We leave this up to the user's preference of input. Some users might just prefer to put general location or postal code. As such we make our address input as permissible as possible. After all, the user can be responsible for the types of addresses they choose to input.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Some users might just prefer to put general location or postal code. 1) Clarifying "user might just prefer to put general location" - eg: that I would think of as general would be lets say Hougang or Punggol, but this defeats the purpose because as an welfare IC i need to know at least the postal code since I might need to send packages or welfare packages to the team member, or require critical information such as Address in case of emergency, such general address would serve no purpose at all, hence I would think that it would be a feature flaw 2) Postal code - this is actually fine, however, there should be exception to handle it then , such as compulosory postal code fields so that in case of emergenct or package/welfare delivery as the welfare IC you will know where to deliver or contact the member.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Should be at least Low or Medium, because putting address as any fields will just means it's another notes field, which defeats the purpose of having an address. Like some online applications that requires a valid address, because only a valid address can serve the real purpose of having an address