Open alshapton opened 1 year ago
Hi Andrew, thanks for getting in contact. I really appreciate you forking and carrying on with the development when I wasn't able to.
I'll happily take a look at your fork and then we can discuss on this issue to come up with a plan to stage some of your changes across, if you're happy with that.
What do you think are the most valuable/high-priority things you've added in your fork?
I would think: i) Configuration using a TOML file ii) ability to change colours (colour-blindness-friendly) iii) exclude specific ADRs from view (e.g. ones which may be out of date) by number iv) Added a new template
A couple of other minor tweaks
I think that colour-blindness-friendly styles in the default template is the highest priority thing to pull across, that would be really useful.
I'm going to spend some time decomposing the __init__.py
file and its corresponding test into smaller chunks, to split the parsing of the ADRs from the rendering of templates, and so any changes to templating would fall into the latter.
OK – Cool – any help you need – gimme.a ping
From: Alex Wilson @.> Date: Friday, 25 August 2023 at 12:14 To: mrwilson/adr-viewer @.> Cc: alshapton @.>, Author @.> Subject: Re: [mrwilson/adr-viewer] Contact (Issue #42)
I think that colour-blindness-friendly styles in the default template is the highest priority thing to pull across, that would be really useful.
I'm going to spend some time decomposing the init.py file and its corresponding test into smaller chunks, to split the parsing of the ADRs from the rendering of templates, and so any changes to templating would fall into the latter.
— Reply to this email directly, view it on GitHubhttps://github.com/mrwilson/adr-viewer/issues/42#issuecomment-1693195451, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABCMMEHZZPXJFRSE6PS753TXXCCI3ANCNFSM6AAAAAA3XQEBBQ. You are receiving this because you authored the thread.Message ID: @.***>
Hi Alex - I know no way of contacting you as the owner of this repo.
Due to the inactivity of this repo, I cloned it and moved it forward with a work colleague so we could use it in our day to day work.
We did much work on it and wish to look at including that work in the main repo now that you have reactivated it.
This is the fork:
https://github.com/alshapton/adr-viewer
We would like to converse about how best to make this happen.
Cheers
Andrew