mrwilson / adr-viewer

Generate easy-to-read web pages for your Architecture Decision Records
MIT License
160 stars 27 forks source link

fix typo and allow list status #9

Closed anis-campos closed 3 years ago

anis-campos commented 3 years ago

There is two fixes in this pr:

  1. The correct spelling is supersede, see https://grammarist.com/spelling/supersede-or-supercede/
  2. Allow a list based status, for example
    ## Status
    * Deprecated
    * Deciders: John Doe
    * Date: 2019-03-14
    * Accepted
    * Deciders: John Doe, Jane Doe
    * Date: 2019-02-14

    the first status is always the current one, but keep the previous status dates and decider for history purposes

anis-campos commented 3 years ago

Hi @mrwilson, I went straight to a PR. Let me know if you need any more clues

mrwilson commented 3 years ago

Thanks for the PR - I ran the tests locally and they failed, I suspect this is because the project currently targets 2.7 and should be upgraded to 3.x soon.

It falls over on yield from - if you're happy to change this into a for foo in bar: yield foo then I can merge this straight away, else I'll need to do the python version upgrade first.