search

mrworf / photoframe

Software to pull random photos from Google Photos and show them, like a photo frame
GNU General Public License v3.0
222 stars 38 forks source link

HEIC Support #146

Open Spencerjuk opened 4 years ago

Spencerjuk commented 4 years ago

HEIC photos do not seem to be supported, is this the case or am I doing something wrong?

mrworf commented 4 years ago

Unfortunately, imagemagick on ARM does not yet support this format. I have contemplated doing a custom build for it, but time has been the limiting factor. If you know of any command line tool which works on raspbian that can convert heic into jpeg or similar, let me know and we can do a workaround for now.

Spencerjuk commented 4 years ago

Thanks for the reply, unfortunately I am a complete novice and therefore I am not aware of any command line tool.

Thanks for you help.

Spencer

On Fri, 13 Dec 2019 at 15:41, Henric Andersson notifications@github.com wrote:

Unfortunately, imagemagick on ARM does not yet support this format. I have contemplated doing a custom build for it, but time has been the limiting factor. If you know of any command line tool which works on raspbian that can convert heic into jpeg or similar, let me know and we can do a workaround for now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mrworf/photoframe/issues/146?email_source=notifications&email_token=AOBBBK7YDMQD5DJEZIPVXULQYOUKDA5CNFSM4J2OKYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG2KW4Y#issuecomment-565488499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOBBBK7V2OZTKUDWEXLILX3QYOUKDANCNFSM4J2OKYEQ .

--

Spencer

mrworf commented 4 years ago

It's on my todo list, but it's a fairly complicated process, so I cannot promised when I'll get the time to do it.

Spencerjuk commented 4 years ago

No worries! I will just convert the ones I want on the frame manually.

On Mon, 16 Dec 2019 at 19:54, Henric Andersson notifications@github.com wrote:

It's on my todo list, but it's a fairly complicated process, so I cannot promised when I'll get the time to do it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mrworf/photoframe/issues/146?email_source=notifications&email_token=AOBBBK6NOIVXNDAMROXJJXLQY7MGJA5CNFSM4J2OKYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG74PVY#issuecomment-566216663, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOBBBK7YBHDU5XY7BQ6WKDDQY7MGJANCNFSM4J2OKYEQ .

--

Spencer

rafik24 commented 4 years ago

Hi @mrworf and @Spencerjuk,

I was looking into converting heif to jpg as many of my pictures are heif and get missed and got to it on the photoframe by upgrading raspbian from Jessie to Buster which provides libheif via apt. I could have compiled on Jessie but they were to many missing dependencies so i decided upgrading would make more sense.

Now I use heif-convert utility and it just works pretty fast as well.

I was wondering if this could be added to the photoframe shall time allow.

Thanks, Rafik

mrworf commented 4 years ago

That's good news indeed, I will take a look and see if it's possible to provide this via the photoframe's update system or a clean upgrade to latest raspbian is a better way to go (probably need to refresh the image anyway at this point).

Good find

dadr commented 3 years ago

I played around with this, and got it working, like rafik24, on a manual install on top of Buster. This is what I learned: Both ImageMagick and also /usr/bin/file need to be updated to recognize the HEIF mime-type. Both are updated in Buster, but neither is available in Stretch - not even as a back port. Then the bad news is that the resize and blur effect does not seem to work properly with these pictures - it gets the border and blur colors all wrong. So I wound up putting in a test for the mime type, and then using convert to JPG anyway. I also determined that when you upload HEIC pictures to Google, it feeds them back to photoframe as JPGs. So not needed there.

mrworf commented 3 years ago

Working on a python3 update will enable us to migrate to newer platform so we can get HEIF support directly. Have actually seen google photos returning HEIF as well, making this update more important than ever :)

b1ane22 commented 2 years ago

Any update on this? I have a bunch of heic files that aren't showing.

dadr commented 2 years ago

Hi b1ane22, HEIC support is in the python 3 pull requests that are in progress, but I have to apologize, and especially to mrworf - I've gotten involved with a startup and it's soaking up a lot of my time. This is something I'm hopeful to get back to in January and maybe even over the holidays. Thanks for your patience and understanding.

b1ane22 commented 2 years ago

Totally understandable! Thanks for the quick response. Good luck with the startup and I'll be looking forward to the update!