search

mrworf / photoframe

Software to pull random photos from Google Photos and show them, like a photo frame
GNU General Public License v3.0
215 stars 38 forks source link

Add web portal address to the FAQs, Wiki, or readme #190

Closed bdhanoa closed 2 years ago

bdhanoa commented 3 years ago

Please add the web portal address with port to the FAQ, Wiki, or Readme.

Currently you have to dig thorough the internet to find out that the web interface address is the following

http://{ipaddress}:7777

mrworf commented 3 years ago

I'm confused. The portal address is unique for each network which is why the frame itself shows the correct URL once it has connected to you wifi. See step 8 on the README.md

dadr commented 3 years ago

I've only ever been confused when I wanted to figure out the portal address for a running system. And as Henric said, the address is dynamic, so it's not going to be something that can just be documented.

bdhanoa commented 3 years ago

I should have noted that the port of the webportal is what we should document. It is static, :7777.

I had a hard time determining the port for the web portal, because I lost my bookmark and I was tying to determine it months after I initially set it up. It is not documented in the readme file.

You are right that the portal ip address is dynamic and depends on the local network and configuration etc.

dadr commented 3 years ago

That would be easy enough to document. Henric - is there a strong reason not to just use port 80? I don't think people are running other web servers on photofames.

mrworf commented 3 years ago

The reason was that as non-root you cannot use ports below 1024 but this is legacy, it runs as root. It can default to 80 and have a command line argument to override if needed (since I don't dev as root 😅 ). But I think a major change like that would need to be part of the other issue I replied to, where we discuss photoframe 2.0 #191 or it would confuse everyone else. Can certainly add port number to the README.md and put a note that rebooting your frame will also show the URL during countdown to start.

bdhanoa commented 3 years ago

Thank you very much!

This is an awesome project.

Congratulations on your success. Thanks for your efforts and for sharing.

dadr commented 3 years ago

The python3 branch runs on port 80. (now)

bdhanoa commented 3 years ago

Thank you very much. That's a good solution.

mrworf commented 2 years ago

Added details about port 7777 in the README.md