search

mrworf / photoframe

Software to pull random photos from Google Photos and show them, like a photo frame
GNU General Public License v3.0
215 stars 38 forks source link

Python3 #192

Open dadr opened 3 years ago

dadr commented 3 years ago

I think this is just a minor change to the Readme.md - to change the install instructions to point to mrworf/python3 instead of my fork. But I also think that GitHub has lost sync of the changes, as it thinks that there are 46 commits I made since the last PR that still must be applied. However, when I look at the code on your python3 branch, it seems up to date with these commits. If I'm doing something wrong with using GitHub, please feel free to share a clue.

dadr commented 3 years ago

This PR now also solves #189

dadr commented 3 years ago

This PR now includes an initial backup-restore function - just for the SD card. Comments/Suggestions?

dadr commented 3 years ago

This PR now also includes #186 - However I have another question. After 5 tries, base.py calls an exception network.RequestNoNetwork. That exception just does a pass. It seems like there was something you wanted to do there and never got to? I'm thinking that the frame should not stop at this point. Rather, it should attempt to show photos from another service or another URL at the same service. If there are no others, then it should probably keep retrying until a network connection comes back. There may be a bigger discussion to have around this - it also seems that services are not given equitable time, and if random order is selected, it seems that pictures could be taken randomly among services. I find it especially difficult to mix the simple URL with either Google Photos or USB photos. The simple URL typically returns different pictures each time it's used (e.g. https://source.unsplash.com/random) and it will get starved for attention when USB photos has a few 100 photos to show.

dadr commented 3 years ago

The new feature/backup commit adds ability to save and restore config from browser.

mrworf commented 3 years ago

Awesome commit, if you could solve the conflict I'll pull it into the branch

mrworf commented 3 years ago

Btw, as a general comment, use the first line in your commit to give a quick summary, don't use it to say what file you changed, since it makes it very hard to see at a glance what commits did what.

mrworf commented 3 years ago

This PR now also includes #186 - However I have another question. After 5 tries, base.py calls an exception network.RequestNoNetwork. That exception just does a pass. It seems like there was something you wanted to do there and never got to? I'm thinking that the frame should not stop at this point. Rather, it should attempt to show photos from another service or another URL at the same service. If there are no others, then it should probably keep retrying until a network connection comes back. There may be a bigger discussion to have around this - it also seems that services are not given equitable time, and if random order is selected, it seems that pictures could be taken randomly among services. I find it especially difficult to mix the simple URL with either Google Photos or USB photos. The simple URL typically returns different pictures each time it's used (e.g. https://source.unsplash.com/random) and it will get starved for attention when USB photos has a few 100 photos to show.

I believe it does? The UX has an option on what to do. Problem is that services cannot hint to the system if they depend on network or not, so instead it will use cached images to continue working when no network is available. If you're referring to the network.py implementation, that's because the exception has no functionality, it's just tossed around. If you look at slideshow.py it catches it and will determine what to do about it until network is back.

mrworf commented 3 years ago

@dadr if you want a more direct comms, feel free to sign up for slack here https://dev.sensenet.nu/ 😄

dadr commented 3 years ago

@mrworf, Thanks for the comments and inputs. I'm working on the changes. I'll let you know when they are done.