search

mrwweb / useful-block-styles

Simple block styles you frequently need for the WordPress Block Editor
GNU General Public License v3.0
4 stars 1 forks source link

Phpcs #6

Closed rtvenge closed 3 years ago

rtvenge commented 3 years ago

@mrwweb could we add WordPress PHPCS Standards?

Thoughts on the VSCode config included? We could always ignore the folder too if you didn't want to clog the repo up with that folder.

mrwweb commented 3 years ago

This seems fine to me. I'm a Sublime guy, so it won't impact me either way. Sticking with the WP PHP standards seems smart, even if there are a few things I've generally quit doing. (Hi, short array syntax!) My big goal with any change it to just avoid much overhead so this plugin remains simple to install and maintain.

rtvenge commented 3 years ago

@mrwweb Thanks for merging!

I know, that array syntax…

I now remember their reasoning:

It’s easier to distinguish from other forms of braces, particularly for those with vision difficulties. It’s much more descriptive for beginners.

I can get there but it's still annoying. 😆

You can write some XML to change rules here and there if you want.

mrwweb commented 3 years ago

I can be open to that. The more JS I write (still not much), the more I want to just write them the same way. That said, I suspect the standard will change in the next year or two (there's discussion), so I'm happy waiting. It's much easier to just follow all the standards rather than all but 1 (then 2, then 3). Back to my point about making it easy to contribute!