mrz1988 / lilies

A cross-platform colored text formatting tool for the command line
MIT License
0 stars 0 forks source link

Port resize into a method outside of lily objects #51

Closed mrz1988 closed 3 years ago

mrz1988 commented 3 years ago

Summary

Remove all resize logic out of LilyBlock and LilyString classes, and create a new resize() helper method. The new resize method:

Technical Implications

Why?

As the repo grows, it makes sense to keep lily text objects a bit thinner, and have powerful helper methods do most of the heavy lifting. This is advantageous for a few reasons:

codecov[bot] commented 3 years ago

Codecov Report

Merging #51 (0e2b633) into master (7e800e6) will decrease coverage by 0.20%. The diff coverage is 91.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   88.12%   87.92%   -0.21%     
==========================================
  Files          34       35       +1     
  Lines        1768     1813      +45     
  Branches      281      301      +20     
==========================================
+ Hits         1558     1594      +36     
- Misses        175      183       +8     
- Partials       35       36       +1     
Impacted Files Coverage Δ
lilies/style/styles.py 100.00% <ø> (ø)
lilies/objects/lilyblock.py 79.88% <76.92%> (-1.71%) :arrow_down:
lilies/api/resize.py 91.30% <91.30%> (ø)
lilies/__init__.py 81.81% <100.00%> (ø)
lilies/api/__init__.py 100.00% <100.00%> (ø)
lilies/api/columnify.py 96.72% <100.00%> (+0.05%) :arrow_up:
lilies/api/grow.py 100.00% <100.00%> (ø)
lilies/objects/lilystring.py 81.61% <100.00%> (-0.33%) :arrow_down:
lilies/style/__init__.py 100.00% <100.00%> (ø)
lilies/compiler/state_manager.py 82.22% <0.00%> (-4.45%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e800e6...0e2b633. Read the comment docs.