search

ms-ati / docile

Docile keeps your Ruby DSLs tame and well-behaved
http://ms-ati.github.com/docile/
MIT License
419 stars 34 forks source link

Add Rubocop and run checks in CI #70

Closed ms-ati closed 3 years ago

ms-ati commented 3 years ago

This should finally allow us to adopt code style lints, as well as others such as performance linting, and have them enforced by the Github Actions continuous integration (CI) jobs.

For now, I'm choosing to depend on the 'panolint' gem from Panorama Education, which is my current workplace, as I'd like to adopt and stay consistent with the setting used there.

Changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #70 (25114d0) into main (cb95b8d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           90        93    +3     
=========================================
+ Hits            90        93    +3
Impacted Files Coverage Δ
lib/docile/chaining_fallback_context_proxy.rb 100.00% <ø> (ø)
lib/docile/version.rb 100.00% <ø> (ø)
lib/docile.rb 100.00% <100.00%> (ø)
lib/docile/backtrace_filter.rb 100.00% <100.00%> (ø)
lib/docile/execution.rb 100.00% <100.00%> (ø)
lib/docile/fallback_context_proxy.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb95b8d...25114d0. Read the comment docs.