search

ms-iot / BusProviders

Repository for Windows IoT Core Bus Provider Libraries
MIT License
40 stars 44 forks source link

Microsoft.IoT.Lightning.Providers initial commit #6

Closed MahmoudGSaleh closed 9 years ago

msftclas commented 9 years ago

Hi @msalehmsft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

bfjelds commented 9 years ago

remove all project.lock.json files

bfjelds commented 9 years ago

be sure to include all sln files (i didn't see one for any blinky* projects)

bfjelds commented 9 years ago

be sure you have LICENSE.txt in all appropriate places

MahmoudGSaleh commented 9 years ago

Thanks! The PR now has the following changes:

  1. Removed references to SDK 10240, and added 10556, min needed for deployment.
  2. Replaced all user references with Microsoft
  3. project.lock.json files removed
  4. Removed top level .sln file
  5. Added new .sln files, one for the provider library and for each of the samples
  6. LICENSE.txt added everywhere, top level and in each of the solutions
bfjelds commented 9 years ago

remove all project.lock.json files

bfjelds commented 9 years ago

check with jesse, but for the sample aggregate provider i'm working on, jesse suggested that the only public constructor be the aggregate constructor.

MahmoudGSaleh commented 9 years ago

Still waiting on the final SDK version to include.