ms-iot / azure-client-tools

Azure Client Tools
Other
43 stars 37 forks source link

DMValidator does not catch boolean mismatches #24

Closed gmileka closed 5 years ago

gmileka commented 5 years ago

Bug description

DMValidator compares the output of an operation to an expected state by traversing the json trees of each. When the leaf node is of type boolean, DMValidator always returns true even if the values differ.

Steps to reproduce

  1. Write a new test case.
  2. In the output include a boolean expected value.
  3. Make sure the handler reports something different from the expected value.
  4. Run the agent.
  5. Run the test.

Observed behavior

DMValidator does not report an error.

Expected behavior

DMValidator should flag the test as a failure and catch the mismatch.

Version (please provide the following information):