search

ms-iot / virtual-shields-arduino

Windows Virtual Shields for Arduino library
MIT License
90 stars 44 forks source link

Restore String API and add HardwareSerial Support #23

Closed sidwarkd closed 8 years ago

msftclas commented 8 years ago

Hi @sidwarkd, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

zfields commented 8 years ago

It looks like all the String replacements are in place. However, I would suggest moving them into inline functions in the .h. That way they can be quickly tossed into an #if defined(ARDUINO) ... block. This would allow VirtualShields to be compiled by a strict C++ compiler.

mwmckee commented 8 years ago

Recent changes reviewed by @zfields and @sidwarkd in person and signed off.