Open stertingen opened 3 years ago
Thanks for the report. Today the extension depends on the behavior of catkin_make in order to find the environment.
Thanks for the report. Today the extension depends on the behavior of catkin_make in order to find the environment.
I'm sorry if I don't get this right, but … catkin tools are currently supported? And most of the time the ROS extension works well with catkin tools, so why was my issue changed to a request for a feature that already exists?
@stertingen There are two sets of Catkin utilities - the official utilities like catkin_make and the catkin tools. We do not test the latter. We have had many reports of it not working. Since it isn't officially supported, this work item is about officially supporting it and testing.
@stertingen There are two sets of Catkin utilities - the official utilities like catkin_make and the catkin tools. We do not test the latter. We have had many reports of it not working. Since it isn't officially supported, this work item is about officially supporting it and testing.
From the marketplace page
The build system (e.g. catkin_make or catkin build) will automatically be confirmed from the hidden files associated with each system.
Has this been implemented, or is the marketplace text referring to something else?
Catkin tools is supported - https://github.com/ms-iot/vscode-ros/blob/master/src/build-tool/catkin-tools.ts. It looks like the check is currently not working.
Linux *** 4.4.0-18362-Microsoft #1049-Microsoft Thu Aug 14 12:01:00 PST 2020 x86_64 x86_64 x86_64 GNU/Linux
)Version of the plugin: v0.6.4
Copy the Version information from the
Help | About
menu:what is the bug
Under some circumstances, the ROS extensions selects the catkin_make build tools when catkin tools would be correct.
Repro steps
catkin_make
build
anddevel
directoriescatkin build
catkin_make
andcatkin_make_isolated
as if the workspace was recently build withcatkin_make
(obviously,catkin_make
fails because the workspace was build withcatkin build
)expected behavior
See
catkin
as build taskadditional context
Currently, the extension detects the build tool by looking if the file
.catkin_workspace
(placed by catkin_make) or the directory.catkin_tools
(placed by catkin build) exist. Both tools also place a file atdevel/.built_by
which contains the name of the build tool (catkin build
orcatkin_make
).(Bonus: Right now the names of the build tasks are very confusing.
catkin_make: build
executescatkin_make
,catkin: make
executescatkin build
. The build task forcatkin build
should becatkin: build
,catkin tools: build
orcatkin tools: make
.)