ms-jpq / coq_nvim

Fast as FUCK nvim completion. SQLite, concurrent scheduler, hundreds of hours of optimization.
GNU General Public License v3.0
3.54k stars 101 forks source link

Question: Specific reason behind 'manual_complete' mapping also in 'Normal' mode? #438

Closed skoenen closed 2 years ago

skoenen commented 2 years ago

I have mapped za to <C-space> to have a convenient way to open and close a fold.

So i thougth, why not set the manual complete to <C-p> instead. Because it is the default mapping for completion in vim in Insert mode. So it does not interfere with settings in Normal mode. So I have a mapping for the fzf plugin to find a file in the current project on <C-p> in Normal mode and then the manual completion in Insert mode.

But this specific line is preventing this: https://github.com/ms-jpq/coq_nvim/blob/9546c14f6664df71b9427b38fcebb7800b69799e/coq/server/registrants/options.py#L70

Therefore my question: Specific reason behind 'manual_complete' mapping also in 'Normal' mode?

Diegovsky commented 2 years ago

I don't like this either. I use <C-space> in normal mode to access buffers and this is not very good. Maybe making this optional by removing it from the code and adding an entry in the custom keybindings section would be better?

Or adding it to the recommended keymaps section to avoid confusion.

I'm not sure how many people use this recommended binding so this could be a bad idea if we break other people's setup :(

ms-jpq commented 2 years ago

https://github.com/ms-jpq/coq_nvim/blob/coq/docs/KEYBIND.md

coq_settings.keymap.manual_complete_insertion_only set this to true to fix this issue :D

Diegovsky commented 2 years ago

Thank you!