ms-studio / karmilla

An expanded version of the amazing Karla webfont, adding support for various languages (French, German, Norse, Hungarian, Latvian, Icelandic...)
Other
150 stars 29 forks source link

Single quotes/apostrophe [‘’] #10

Closed nclm closed 10 years ago

nclm commented 10 years ago

Hi! Nice adjustment of the ’ in Karmilla! Some related additional things I’m thinking about:

‘’

I’d love to try doing the revisions by the way (I’m waiting for your answer first) — I want to contribute to an open typeface for a while now, and I really like Karla Karmilla.

ms-studio commented 10 years ago

Indeed, I corrected it only in the Regular weight, and for the only apostrophe that is used in French.

You are right, it would be good to align the others as well – feel free to go ahead.

Nice to have more contributors!

nclm commented 10 years ago

I did the changes and sent a pull request for you to review: #12 :) Was not sure how to do for the versioning, so there’s an edited font-log but maybe it’s not right. Also are exported two .ttf, but the files are lighter than the previous ones while I didn’t removed anything. Maybe something to do with export settings? Anyhow, glad to contribute even at such a small level!