Finish supporting Romanian in bold weight

[akaleeroy]

Romanian diacritics ȘșȚțĂăÎîÂâ are supported but ȘșȚț bold glyphs are missing.

They're U+0218, U+0219, U+021a, U+021b

Thank you!

[andrewshadura]

In fact 68b0650 and eae9566 added these back in 2015.

[akaleeroy]

I think the mistake is in src/Karmilla-Bold.sfdir/tcommaaccent.glyph

That glyph is latin small letter t with cedilla (U+0163) but for Romanian (and as per the filename) it should be latin small letter t with comma below (U+021B)

This is the most common confusion with Romanian diacritics. Microsoft got it wrong in a legacy keyboard layout and now the confusion persists decades later. The letters with cedilla are from Turkish, the Romanian ones are with comma below.

Also noticed the glyphs that display Ă and ă correspond to the code points of Ć and ć.

Letter	Unicode code point	Decimal
Ș	U+0218	536
ș	U+0219	537
Ț	U+021a	538
ț	U+021b	539
Ă	U+0102	258
ă	U+0103	259

Again, this is on the Bold variant, the Regular is fine.

Beautiful typeface BTW, thank you!

[andrewshadura]

I'm not quite sure what you mean since the font has both glyphs with cedillas and with commas. What could be done though is that in Romanian text the letters with cedillas would use the glyphs of letters with commas.

On Tue, 17 Nov 2020, at 13:27, Leeroy wrote:

I think the mistake is in src/Karmilla-Bold.sfdir/tcommaaccent.glyph https://github.com/ms-studio/karmilla/commit/68b06506911f568abe0d1264fd9b53f1ca8b902b#diff-1431a3cb63b87b03a8e6f53b70a34e6c2f7108ddd731d60d0f7a55e0edcd0f1d

That glyph is latin small letter t with cedilla (U+0163) https://graphemica.com/%C5%A3 but for Romanian (and as per the filename) it should be latin small letter t with comma below (U+021B) https://graphemica.com/%C8%9B

This is the most common confusion with Romanian diacritics. Microsoft got it wrong in a legacy keyboard layout and now the confusion persists decades later. The letters with cedilla are from Turkish, the Romanian ones are with comma below.

Letter Unicode code point Decimal Ș U+0218 536 ș U+0219 537 Ț U+021a 538 ț U+021b 539 Beautiful typeface BTW, thank you!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ms-studio/karmilla/issues/52#issuecomment-728894426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACLQBOAKGUVXYUII2DGGA3SQJT4TANCNFSM4IS4RZ6Q.

-- Cheers, Andrej

[akaleeroy]

@andrewshadura Updated previous comment with some clarifications.

I see the .glyph files exist but the characters are missing in Karmilla-Bold.ttf and karmilla-bold-webfont.ttf. I used FontForge to open the TrueType font files.

[andrewshadura]

I guess you need to open sfdir and regenerate the TTF.

[andrewshadura]

[akaleeroy]

I guess you need to open sfdir and regenerate the TTF.

That did the trick! :tada:
So the .ttf files in /dist/ are out of date. Could you please re-generate them the next time you contribute something?

Thanks for the help!

[andrewshadura]

If you’re using Debian or Ubuntu, you can install fonts-karmilla which ships a 2018 version of the fonts.