search

ms11 / 4chanSoundPlayer

Play those sound from those images!
10 stars 1 forks source link

New way of adding sounds #25

Open friendlyanon opened 11 years ago

friendlyanon commented 11 years ago

So, GitHub is a dick and won't let my comment through on issue #24

Is it possible to work with the actual hex codes in ArrayBuffer/Uint8Array? I've just posted an image file with embedded sound, but the only modification I did is shifting the hex value of every byte by 1 after the [tag] like this

5B 31 5D 0A 4F 67 67 53
[1]
OggS

becomes

5B 31 5D 0B 50 68 68 54
[1]PhhT

If it's possible, then it'll be just the simplest thing to make 4chan sounds work, and fixing oggchan to batch run this shifting on older images

EDIT: 4chan flips shit if there's a newline ( 0A ) after the closing square bracket ( 5D ) even with the sound data shifted by 1.

EDIT2: GitHub still won't let me comment. If any further info/suggestion needed, look up HandyAnon@Steam

nstepien commented 11 years ago

Isn't that just as easy to block as it was before? Wouldn't it be possible to insert the sound in the exif data or something? These things can contain icc profiles iirc so it shouldn't be a problem.

nstepien commented 11 years ago

I receive your comment via mail notification, friendlyanon. Try answering via mail maybe github will like it better.

friendlyanon commented 11 years ago

Test

Well, it took moot years to add 4chan sounds to the filter. And I don't think every image type that can be posted on 4chan has exif data.

2012/12/2, Mayhem notifications@github.com:

I receive your mail, friendlyanon. Try answering via mail maybe github will like it better.

Reply to this email directly or view it on GitHub: https://github.com/ms11/4chanSoundPlayer/issues/25#issuecomment-10936669