ms32035 / firefly-iii-client

Python client for Firefly III API. Please read .generator/Readme.md
19 stars 8 forks source link

Access Token is set to None in Configuration #19

Closed mukundv closed 3 months ago

mukundv commented 11 months ago

https://github.com/ms32035/firefly-iii-client/blob/379f88b8d9b3fa0d5819fa26004fc97c39319b3d/firefly_iii_client/configuration.py#L114 Not an expert, but this line is causing authentication to fail. Shouldn't this be self.access_token = access_token

daviterri commented 4 months ago

Yes, I was having trouble with the authentication, this fixed it

https://github.com/ms32035/firefly-iii-client/blob/379f88b8d9b3fa0d5819fa26004fc97c39319b3d/firefly_iii_client/configuration.py#L114

Not an expert, but this line is causing authentication to fail. Shouldn't this be self.access_token = access_token

soloam commented 3 months ago

I also noticed this! What is the reason to have this set to none? Can't we use the api with token?

ms32035 commented 3 months ago

@soloam the reason was a bug in the openapi generator, which they now fixed. Please try release 2.0.12.0