ms705 / nom-sql

Rust SQL parser written using nom
MIT License
232 stars 41 forks source link

Upgrade to latest version of nom #11

Closed jonhoo closed 6 years ago

jonhoo commented 7 years ago

The version of nom currently used by nom-sql is fairly old. In and of itself, this isn't so bad (though the newer nom presumably has performance and correctness fixes), but it causes some pain with dependencies. Specifically, the old version of num depends on regex 0.1, whereas regex is now at 0.2 (which is incompatible according to Rust's semver). regex 0.1 in turn has a bunch of outdated dependencies (compare 0.1 to current). These in turn pull in more old dependencies, etc. For crates that use nom-sql this causes many dependencies to be pulled in twice (one old, one new), which has a detrimental effect on compilation time and space usage.

I know fixing this is a bit annoying, as the nom api has changed a fair bit, but it's probably eventually worth doing.

ms705 commented 6 years ago

Done as per #14!