search

msDesc / consolidated-tei-schema

TEI Manuscript Description ODD Customisation
https://raw.githubusercontent.com/msdesc/consolidated-tei-schema/master/msdesc.rng
BSD 2-Clause "Simplified" License
16 stars 7 forks source link

Improve gap rendering #41

Closed holfordm closed 3 years ago

holfordm commented 3 years ago

attempts to address issue #40

andrew-morrison commented 3 years ago

What should be displayed when the gap has no @unit, or a @reason which is something other than "editorial"?

holfordm commented 3 years ago

ellipsis with no spaces either side. Editorial gaps could be further distinguished by appearing as " [...] " i.e. space either side of ellipsis in square brackets.

andrew-morrison commented 3 years ago

In that case the [not(@unit) and not(@reason)] should be removed. In XSLT, templates with more specific matches take precedence over more generic ones. So you can (and probably should) have one template that just matches any gap element, doing the default, then override that with templates for specific cases (like the editorial ones.)

If you want square brackets around the ellipsis for editorial gaps, then add those into the XSLT.

holfordm commented 3 years ago

On closer investigation I see the existing templates are working in some contexts (e.g. https://medieval.bodleian.ox.ac.uk/catalog/manuscript_107) and the problem is in the use of char / chars, which I'll fix.

andrew-morrison commented 3 years ago

Probably best to standardize on char as that is what the TEI schema suggests, so is what Oxygen offers in an autocomplete drop-down.

andrew-morrison commented 3 years ago

I have re-indexed Medieval QA, using the latest TEI from the master branch of medieval-mss, and XSLT from this branch, if you want to see the effect of your changes to gap.

I'll merge then re-index production at the end of today, unless I hear otherwise.