msDesc / consolidated-tei-schema

TEI Manuscript Description ODD Customisation
https://raw.githubusercontent.com/msdesc/consolidated-tei-schema/master/msdesc.rng
BSD 2-Clause "Simplified" License
16 stars 7 forks source link

Changes june 2021 #43

Closed holfordm closed 3 years ago

andrew-morrison commented 3 years ago

Both damage elements and defective attributes are used in other catalogues. Is the notation being added by the stylesheet specific to Medieval or universal?

There is nothing wrong with the XSLT syntax.

holfordm commented 3 years ago

Even within medieval Western catalogues, notation for these things varies, but I think this notation is universally comprehensible. Certainly the defective ttribute is just an extension of what we already have for incipit and explicit. Do we have colleagues from Fihrist or other catalogues on this repo who might comment?

andrew-morrison commented 3 years ago

Looking more closely, damage has been used by a couple of Fihrist institutions to mark up descriptions of damage in physDesc. For example:

You could add some context, so the new template only matches damage when inside certain other elements, but if the above are using it wrong it might be just as well to keep it as-is, to discourage further incorrect usage.

There are very little usage of rubric or finalRubric, and none with the defective attribute, but here's an example in Fihrist of the defective attribute in both incipit and explicit:

Which is displayed like this:

Alasdair created that record after the new Fihrist web site launched, so it would've displayed that way when he did so.

holfordm commented 3 years ago

The current guidelines are clear that it should be used for "an area of damage to the text witness." Extending that to use the element to describe the nature of damage to an object is perhaps logical but strictly should either be noted in our ODD or submitted to TEI council. (Can we pass this on to the Fihrist mailing list?)

andrew-morrison commented 3 years ago

I've sent an email to the Fihrist mailing list.

I've now merged this pull request. I don't create new releases for tweaks to the XSLT.