msa7 / multi_auth

Standardized multi-provider OAuth authentication
MIT License
111 stars 23 forks source link

Add instructions for Lucky Framework integration #7

Closed mikeeus closed 6 years ago

mikeeus commented 6 years ago

Hi, thanks for the great shard. I used it in a lucky project and I thought it would be nice to have instructions for others doing the same.

mikeeus commented 6 years ago

K I made it more flexible, what do you think?

Also are you planning to add support for passing in scopes and fields?

msa7 commented 6 years ago

Changes look good, I will simplify a bit your example. I am planning to support for passing in scopes. No for fields since it could be done as additional request in application specific logic

msa7 commented 6 years ago

Thanks for PR!

mikeeus commented 6 years ago

@msa7 Great! I'm looking forward to the scopes. This is a really useful shard, thanks for making it :+1:

msa7 commented 6 years ago

@mikeeus PR for the scope is welcome

mikeeus commented 6 years ago

Actually I just checked and the scope seems to be working when you pass it through authorize_uri("email,public_profile"). So it's looking good, thanks!